linux-kernel - Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170701025509.GB11217@localhost.localdomain>
Date:   Fri, 30 Jun 2017 19:55:11 -0700
From:   Eduardo Valentin <edubezval@...il.com>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        rjui@...adcom.com, sbranden@...adcom.com, kernel@...tin.sperl.org,
        rafal@...ecki.pl, eric@...olt.net, rui.zhang@...el.com,
        bcm-kernel-feedback-list@...adcom.com, f.fainelli@...il.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] thermal: bcm2835: Fix error code in
 'bcm2835_thermal_probe'

On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote:
> 
> > Christophe JAILLET <christophe.jaillet@...adoo.fr> hat am 23. Juni 2017 um 21:44 geschrieben:
> > 
> > 
> > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is
> > pointless.
> > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above.
> > So remove it. 'err' is already the error we want to report.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Thanks, but Dan Carpenter already send a fix for this.

Yeah, and I applied Dan's version as it was coming first in my queue. Sorry.