linux-kernel - Re: [PATCH] Replaced Function name in debug print with %s..., __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1499012025.9885.5.camel@perches.com>
Date:   Sun, 02 Jul 2017 09:13:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Gaurav Pathak <gauravpathak129@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Replaced Function name in debug print with %s...,
 __func__

On Sun, 2017-07-02 at 19:41 +0530, Gaurav Pathak wrote:
> Signed-off-by: Gaurav Pathak <gauravpathak129@...il.com>

Need a different subject like:

[PATCH] staging: rts5208: Replace embedded function names with "%s: ", __func__

and you also require some change log like

Avoid possible defects when refactoring.

> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
[]
> @@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
>  
>  		if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
>  			chip->rw_need_retry = 0;
> -			dev_dbg(rtsx_dev(chip), "No card exist, exit mspro_rw_multi_sector\n");
> +			dev_dbg(rtsx_dev(chip), "No card exist, %s\n",
> +				__func__);

try not to change output too.

You could also drop what appear to be function tracing
style logging where the message is the equivalent of:

void func(args...)
{
	dev_dbg("%s: entered\n", __func__)
	...
}

as the generic function tracing mechanism works well.