linux-kernel - Re: [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jul 2017 21:30:30 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Wolfram Sang <wsa@...-dreams.de>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Linux-SH <linux-sh@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] i2c: pca-platform: propagate error from
 i2c_pca_add_numbered_bus

On 30/06/17 20:40, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 3:54 AM, Chris Packham
> <chris.packham@...iedtelesis.co.nz> wrote:
>> Rather than returning -ENODEV if i2c_pca_add_numbered_bus() fails,
>> propagate the error to aid debugging.
>>
> 
> + Suggested-by ?
> 
> You or Wolfram can use below if you agree on it (I'm fine either way):
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 

I'll include it (and the Reviewed-by) in v2 if there is one.

>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> 
>> ---
>>   drivers/i2c/busses/i2c-pca-platform.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
>> index daccef6865e8..853a2abedb05 100644
>> --- a/drivers/i2c/busses/i2c-pca-platform.c
>> +++ b/drivers/i2c/busses/i2c-pca-platform.c
>> @@ -232,9 +232,9 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
>>                          return ret;
>>          }
>>
>> -       if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> -               return -ENODEV;
>> -       }
>> +       ret = i2c_pca_add_numbered_bus(&i2c->adap);
>> +       if (ret)
>> +               return ret;
>>
>>          platform_set_drvdata(pdev, i2c);
>>
>> --
>> 2.13.0
>>
> 
> 
>