linux-kernel - Re: [PATCH] PCI: xilinx: make of_device_ids const.

Open Source and information security mailing list archives

Message-ID: <20170702214932.GI18324@bhelgaas-glaptop.roam.corp.google.com>
Date:   Sun, 2 Jul 2017 16:49:32 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     bhelgaas@...gle.com, po.liu@....com, paul.gortmaker@...driver.com,
        lorenzo.pieralisi@....com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: xilinx: make of_device_ids const.

On Tue, Jun 20, 2017 at 11:17:48AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     195	    600	      0	    795	    31b	drivers/pci/host/pcie-xilinx.o
> 
> File size after constify xilinx_pcie_of_match:
>    text	   data	    bss	    dec	    hex	filename
>     595	    184	      0	    779	    30b	drivers/pci/host/pcie-xilinx.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied to pci/host-xilinx for v4.13, thanks!

> ---
>  drivers/pci/host/pcie-xilinx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
> index 2fe2df5..b621cb5 100644
> --- a/drivers/pci/host/pcie-xilinx.c
> +++ b/drivers/pci/host/pcie-xilinx.c
> @@ -696,7 +696,7 @@ static int xilinx_pcie_probe(struct platform_device *pdev)
>  	return err;
>  }
>  
> -static struct of_device_id xilinx_pcie_of_match[] = {
> +static const struct of_device_id xilinx_pcie_of_match[] = {
>  	{ .compatible = "xlnx,axi-pcie-host-1.00.a", },
>  	{}
>  };
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives