linux-kernel - Re: [PATCH 09/21] x86/intel_rdt: Simplify info and base file lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jul 2017 12:09:49 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>
cc:     x86@...nel.org, linux-kernel@...r.kernel.org, hpa@...or.com,
        peterz@...radead.org, ravi.v.shankar@...el.com,
        vikas.shivappa@...el.com, tony.luck@...el.com,
        fenghua.yu@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH 09/21] x86/intel_rdt: Simplify info and base file lists

On Mon, 26 Jun 2017, Vikas Shivappa wrote:
> @@ -82,6 +82,7 @@ struct rdt_resource rdt_resources_all[] = {
>  		},
>  		.parse_ctrlval		= parse_cbm,
>  		.format_str		= "%d=%0*x",
> +		.fflags			= RFTYPE_RES_CACHE,
>  	},

Can you please convert that array to use explicit array member
initializers? I've noticed this back when I reviewed the intial RDT
implementation, but it somehow escaped. i.e.:

      [RESOURCE_ID] =
      {
	.....
      }

Thanks,

	tglx