linux-kernel - Re: [PATCH] zram: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89a0004e-89dc-7d06-7b5b-091677074a8c@gmail.com>
Date:   Mon, 3 Jul 2017 12:48:32 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Minchan Kim <minchan@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     ngupta@...are.org, sergey.senozhatsky.work@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: constify attribute_group structures.

Hi,


On Monday 03 July 2017 11:57 AM, Minchan Kim wrote:
> Hello,
>
> On Mon, Jul 03, 2017 at 11:43:13AM +0530, Arvind Yadav wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work with const
>> attribute_group. So mark the non-const structs as const.
> If so, how about changing all of places where not have used const
> as well as zram?
      Sure, I am going to change other place also.
>
> Anyway, I'm okay with this.
>
>> File size before:
>>     text	   data	    bss	    dec	    hex	filename
>>     8293	    841	      4	   9138	   23b2	drivers/block/zram/zram_drv.o
>>
>> File size After adding 'const':
>>     text	   data	    bss	    dec	    hex	filename
>>     8357	    777	      4	   9138	   23b2	drivers/block/zram/zram_drv.o
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> Acked-by: Minchan Kim <minchan@...nel.org>
>
> Thanks.
Thanks,
~arvind