linux-kernel - Re: [PATCH] drm/udl: dma-buf: Constify dma_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Jul 2017 10:08:13 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     airlied@...hat.com, airlied@...ux.ie, daniel.vetter@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/udl: dma-buf: Constify dma_buf_ops structures.

On Sat, Jul 01, 2017 at 06:06:46PM +0530, Arvind Yadav wrote:
> dma_buf_ops are not supposed to change at runtime. All functions
> working with dma_buf_ops provided by <linux/dma-buf.h> work with
> const dma_buf_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2002	    112	      0	   2114	    842	drivers/gpu/drm/udl/udl_dmabuf.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    2114	      0	      0	   2114	    842	drivers/gpu/drm/udl/udl_dmabuf.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

I merged the two armada and the one udl fix to drm-misc-next for 4.14.
I'll leave the radeon one to Alex.

Thanks, Daniel

> ---
>  drivers/gpu/drm/udl/udl_dmabuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_dmabuf.c b/drivers/gpu/drm/udl/udl_dmabuf.c
> index ed0e636..61a5a5f 100644
> --- a/drivers/gpu/drm/udl/udl_dmabuf.c
> +++ b/drivers/gpu/drm/udl/udl_dmabuf.c
> @@ -186,7 +186,7 @@ static int udl_dmabuf_mmap(struct dma_buf *dma_buf,
>  	return -EINVAL;
>  }
>  
> -static struct dma_buf_ops udl_dmabuf_ops = {
> +static const struct dma_buf_ops udl_dmabuf_ops = {
>  	.attach			= udl_attach_dma_buf,
>  	.detach			= udl_detach_dma_buf,
>  	.map_dma_buf		= udl_map_dma_buf,
> -- 
> 2.7.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch