lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 3 Jul 2017 10:30:32 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lynn Lei <lynnl.wit@...il.com>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: fixed a assignment typo

On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote:
> fixed a typo issue in get_mxclk_freq().
> 
> the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
> which is not right, it should be PLL_CTRL_N_SHIFT.
> 
> both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
>   defined in drivers/staging/sm750fb/ddk750_reg.h
> 
> Signed-off-by: Lynn Lei <lynnl.wit@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Always put what changed from the previous version here below the ---
line, like the Documentation states to do.

v3 please?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ