linux-kernel - Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170703085323.ph5drwiisjxmfhri@localhost.localdomain>
Date:   Mon, 3 Jul 2017 09:53:23 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Baolin Wang <baolin.wang@...aro.org>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>, <sre@...nel.org>,
        <jun.li@....com>, <peter.chen@...escale.com>, <broonie@...nel.org>,
        <john.stultz@...aro.org>, <neilb@...e.com>,
        <patches@...nsource.wolfsonmicro.com>, <linux-pm@...r.kernel.org>,
        <linux-usb@...r.kernel.org>,
        <device-mainlining@...ts.linuxfoundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current
 limit management

On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote:
> Integrate with the newly added USB charger interface to limit the current
> we draw from the USB input based on the input device configuration
> identified by the USB stack, allowing us to charge more quickly from high
> current inputs without drawing more current than specified from others.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---
<snip>
>  /*********************************************************************
>   *		Battery properties
>   *********************************************************************/
> @@ -607,6 +647,22 @@ static int wm831x_power_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> +	power->usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev,
> +						     "usb-phy", 0);
> +	if (IS_ERR(power->usb_phy)) {
> +		ret = PTR_ERR(power->usb_phy);
> +		dev_err(&pdev->dev, "Failed to find USB phy: %d\n", ret);
> +		goto err_bat_irq;
> +	}
> +

We should probably update the binding documentation for this as
well: mfd/wm831x.txt

Also I am not sure this needs to be implemented now, but what is
the plan regarding pdata systems? Generally the driver supports
both and it would be nice to know there is a way forward for that
even if we don't implement it yet.

Thanks,
Charles