linux-kernel - Re: [PATCH] cpufreq: intel_pstate: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Jul 2017 14:30:45 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     srinivas.pandruvada@...ux.intel.com, lenb@...nel.org,
        rjw@...ysocki.net, rafael.j.wysocki@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: constify attribute_group
 structures.

On 03-07-17, 13:40, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15197	   2552	     40	  17789	   457d	drivers/cpufreq/intel_pstate.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15261	   2488	     40	  17789	   457d	drivers/cpufreq/intel_pstate.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b7de5bd..4323f94 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b,
>  	NULL
>  };
>  
> -static struct attribute_group intel_pstate_attr_group = {
> +static const struct attribute_group intel_pstate_attr_group = {
>  	.attrs = intel_pstate_attributes,
>  };

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh