linux-kernel - Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from apic_bsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bacfc29-ab66-2749-ceca-f1377c5fed90@cn.fujitsu.com>
Date:   Mon, 3 Jul 2017 10:02:45 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <mingo@...nel.org>,
        <hpa@...or.com>, <ebiederm@...ssion.com>, <bhe@...hat.com>,
        <boris.ostrovsky@...cle.com>, <peterz@...radead.org>,
        <izumi.taku@...fujitsu.com>
Subject: Re: [PATCH v5 04/12] x86/apic: Move logical APIC ID away from
 apic_bsp_setup()

Hi, Thomas

At 07/03/2017 01:54 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>>  /*
>> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>> index 93f0cda..d6721f0 100644
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -1347,8 +1347,11 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
>>  	}
>>
>>  	default_setup_apic_routing();
>> -	cpu0_logical_apicid = apic_bsp_setup(false);
>> -
>> +	apic_bsp_setup(false);
>> +	if (x2apic_mode)
>> +		cpu0_logical_apicid = apic_read(APIC_LDR);
>> +	else
>> +		cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR));
>
> Can you please move that into a seperate helper function?


Yes, it will be a separate helper function in the next version.

Thanks,

	dou.

>
>>  	/* Setup local timer */
>>  	x86_init.timers.setup_percpu_clockev();
>>
>> --
>> 2.5.5
>>
>>
>>
>>
>
>
>