linux-kernel - Re: [PATCH v5 05/12] x86/apic: Unify interrupt mode setup for SMP-capable system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e10a49b5-faf9-2d64-2006-84e518851d19@cn.fujitsu.com>
Date:   Mon, 3 Jul 2017 10:34:57 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <mingo@...nel.org>,
        <hpa@...or.com>, <ebiederm@...ssion.com>, <bhe@...hat.com>,
        <boris.ostrovsky@...cle.com>, <peterz@...radead.org>,
        <izumi.taku@...fujitsu.com>
Subject: Re: [PATCH v5 05/12] x86/apic: Unify interrupt mode setup for
 SMP-capable system

Hi Thomas,

At 07/03/2017 02:07 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>> -static int __init apic_intr_mode_select(void)
>> +static int __init apic_intr_mode_select(int *upmode)
>>  {
>>  	/* Check kernel option */
>>  	if (disable_apic) {
>> @@ -1206,12 +1208,30 @@ static int __init apic_intr_mode_select(void)
>>  	if (!smp_found_config) {
>>  		disable_ioapic_support();
>>
>> -		if (!acpi_lapic)
>> +		if (!acpi_lapic) {
>>  			pr_info("APIC: ACPI MADT or MP tables are not detected\n");
>> +			*upmode = true;
>
> That store and extra argument is pointless.
>
>> +
>> +			return APIC_VIRTUAL_WIRE_NO_CONFIG;
>
> You added an extra return code, which you can use exactly for that purpose
> at the callsite.
>

Actually indeed. Great! Why didn't I think of that?

>
> Aside of that, if you use int * then use numbers, if you use bool then use
> true/false. But mixing that is horrible.
>

Yes, it is, I will remove the 'upmode' argument.


Thanks,

	dou.

>> +		}
>
> Thanks,
>
> 	tglx
>
>
>