linux-kernel - Re: [PATCH 2/4] perf/x86: Fix data source decoding for Skylake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1707031236300.2188@nanos>
Date:   Mon, 3 Jul 2017 12:38:41 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andi Kleen <andi@...stfloor.org>
cc:     peterz@...radead.org, acme@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/4] perf/x86: Fix data source decoding for Skylake

On Wed, 21 Jun 2017, Andi Kleen wrote:
> I didn't add a generic flag for hops because it's not needed
> for Skylake.

When is that going to come? 

> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index b1c0b187acfe..7cfeb54e0b5a 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -931,14 +931,20 @@ union perf_mem_data_src {
>  			mem_snoop:5,	/* snoop mode */
>  			mem_lock:2,	/* lock instr */
>  			mem_dtlb:7,	/* tlb access */
> -			mem_rsvd:31;
> +			mem_lvl_num:4,	/* memory hierarchy level number */
> +			mem_remote:1,   /* remote */
> +			mem_snoopx:2,	/* snoop mode, ext */

Is that extending snoopx another time?

The question really is, whether the 2 bits are going to be sufficient for a
while or are we going to add snoopx2 in a few month from now.

Thanks,

	tglx