linux-kernel - Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170703114641.2zivoeqiv7tk4bqu@dell>
Date:   Mon, 3 Jul 2017 12:46:41 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Benson Leung <bleung@...gle.com>
Cc:     Thierry Escande <thierry.escande@...labora.com>,
        Benson Leung <bleung@...omium.org>,
        linux-kernel@...r.kernel.org, enric.balletbo@...labora.com
Subject: Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake
 host events

On Tue, 27 Jun 2017, Benson Leung wrote:

> Hi Thierry,
> 
> On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > From: Shawn Nematbakhsh <shawnn@...omium.org>
> > 
> > The subset of wake-enabled host events is defined by the EC, but the EC
> > may still send non-wake host events if we're in the process of
> > suspending. Get the mask of wake-enabled host events from the EC and
> > filter out non-wake events to prevent spurious aborted suspend
> > attempts.
> > 
> > Signed-off-by: Shawn Nematbakhsh <shawnn@...omium.org>
> > Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> > ---
> >  drivers/mfd/cros_ec.c                   | 13 ++++--
> >  drivers/platform/chrome/cros_ec_proto.c | 76 ++++++++++++++++++++++++++++++---
> >  include/linux/mfd/cros_ec.h             |  5 ++-
> >  3 files changed, 85 insertions(+), 9 deletions(-)
> > 
> 
> Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since
> this patch was posted, so I went ahead and modified that too.
> 
> Applied. Thanks.

No need to change anything this time, but please note the "for my own
reference" in my Ack in future.  It typically means that I plan on
pushing it through the MFD tree or that it requires further discussion
(in the case that another Maintainer would prefer it go through their
tree).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog