linux-kernel - Re: [PATCH] ARM: owl: smp: Drop bogus holding pen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3R9g2S4cPDhgYK2rPmLxjvs0ki1kg5vY_1zPZwcbttQQ@mail.gmail.com>
Date:   Mon, 3 Jul 2017 14:35:31 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        mp-cs@...ions-semi.com, Thomas Liau <thomas.liau@...ions-semi.com>,
        张东风 <zhangdf@...ions-semi.com>,
        刘炜 <liuwei@...ions-semi.com>,
        张天益 <tyzhang@...ions-semi.com>,
        梅利 <harrymei@...ions-semi.com>,
        support@...aker.org, support@...ietech.com, lee@...ietech.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH] ARM: owl: smp: Drop bogus holding pen

On Sat, Jul 1, 2017 at 11:29 PM, Andreas Färber <afaerber@...e.de> wrote:
> The S500 SoC can start secondary CPUs without busy-looping for pen_release,
> so simplify the SMP code compared to the LeMaker kernel tree.
>
> Fixes: 172067e0bc87 ("ARM: owl: Implement CPU enable-method for S500")
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Cc: David Liu <liuwei@...ions-semi.com>
> Signed-off-by: Andreas Färber <afaerber@...e.de>

Looks good to me. I applied both on top of next/soc before tagging the
branch for 4.13,
so this version is going to be what we merge.

I saw that David had another suggestion for simplifying it further.
That also looks
good, but it's less urgent, so please implement that as an add-on patch and send
it for 4.14, unless you decide there is a reason it needs to be
included in 4.13 as
well.

Thanks!

        Arnd