linux-kernel - Re: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170703130739.GD13824@bhelgaas-glaptop.roam.corp.google.com>
Date:   Mon, 3 Jul 2017 08:07:39 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ryder Lee <ryder.lee@...iatek.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags

On Mon, Jul 03, 2017 at 01:55:00PM +0800, Ryder Lee wrote:
> The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed,
> since we should automatically assign resources if the firmware hasn't done it.
> 
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>

Folded into pci/host-mediatek, thanks!

> ---
>  drivers/pci/host/pcie-mediatek.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
> index 51c6118..5a9d858 100644
> --- a/drivers/pci/host/pcie-mediatek.c
> +++ b/drivers/pci/host/pcie-mediatek.c
> @@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host)
>  	struct pci_bus *child;
>  	int err;
>  
> -	pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
>  	host->busnr = pcie->busn.start;
>  	host->dev.parent = pcie->dev;
>  	host->ops = &mtk_pcie_ops;
> -- 
> 1.9.1
>