linux-kernel - Re: Applied "spi: imx: dynamic burst length adjust for PIO mode" to the spi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170703151234.q3fd7vehoyz62qu3@sirena.org.uk>
Date:   Mon, 3 Jul 2017 16:12:34 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Sascha Hauer <s.hauer@...gutronix.de>
Cc:     Jiada Wang <jiada_wang@...tor.com>, festevam@...il.com,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Applied "spi: imx: dynamic burst length adjust for PIO mode" to
 the spi tree

On Fri, Jun 30, 2017 at 02:14:33PM +0200, Sascha Hauer wrote:

> This is wrong. MX51_ECSPI_CTRL_MAX_BURST contains the burst length in
> bytes, but the register 'val' is written to takes the burst length in
> bits - 1, so this should be:

> 			val = MX51_ECSPI_CTRL_MAX_BURST * 8 - 1;

> instead.

Well, it breaks the build anyway so I'll revert.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)