linux-kernel - Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <595A88C202000078001680C2@prv-mh.provo.novell.com>
Date:   Mon, 03 Jul 2017 10:11:14 -0600
From:   "Jan Beulich" <JBeulich@...e.com>
To:     "Juergen Gross" <jgross@...e.com>
Cc:     <xen-devel@...ts.xenproject.org>, <boris.ostrovsky@...cle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory
 initially

>>> On 03.07.17 at 17:40, <jgross@...e.com> wrote:
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -59,6 +59,8 @@ static void watch_target(struct xenbus_watch *watch,
>  {
>  	unsigned long long new_target;
>  	int err;
> +	static bool watch_fired;
> +	static unsigned long target_diff;

It would seem to me that the types of target_diff and new_target
should match in width, but differ in signedness.

Jan