linux-kernel - Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170704083045.fqruqn6i5sxhfhu6@localhost.localdomain>
Date:   Tue, 4 Jul 2017 09:30:45 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     <linux-gpio@...r.kernel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        David Cohen <david.a.cohen@...ux.intel.com>,
        Scott Branden <sbranden@...adcom.com>,
        <linux-acpi@...r.kernel.org>,
        <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Alexander Shiyan <shc_work@...l.ru>,
        Michal Simek <michal.simek@...inx.com>,
        Kevin Hilman <khilman@...nel.org>,
        <linux-tegra@...r.kernel.org>, Joel Stanley <joel@....id.au>,
        <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        "Mika Westerberg" <mika.westerberg@...ux.intel.com>,
        <patches@...nsource.cirrus.com>, Alban Bedel <albeu@...e.fr>,
        <linux-kernel@...r.kernel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        "Thor Thayer" <thor.thayer@...ux.intel.com>,
        Tien Hock Loh <thloh@...era.com>
Subject: Re: [PATCH] gpio: drop unnecessary includes from
 include/linux/gpio/driver.h

On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote:
> Some of include directives in include/linux/gpio/driver.h are
> unneeded because the header does not need to know the content of
> struct device, irq_chip, etc.  Just declare they are structures.
> 
> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
> turned out to be necessary for irq_flow_handler_t and spinlock_t,
> respectively.
> 
> Each driver should include what it needs without relying on what is
> implicitly included from <linux/gpio/driver.h>.  This will cut down
> unnecessary header parsing.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/gpio/gpio-wm831x.c       |  1 +
>  drivers/gpio/gpio-wm8994.c       |  1 +

For the Wolfson Micro bits:

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles