linux-kernel - Re: [PATCH 4/6] ARM: dts: rockchip: enable eMMC for rk3229-evb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4792016.SK4QvSrg4n@diego>
Date:   Tue, 04 Jul 2017 10:35:44 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Frank Wang <frank.wang@...k-chips.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, linux@...linux.org.uk,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        huangtao@...k-chips.com, kever.yang@...k-chips.com,
        david.wu@...k-chips.com, finley.xiao@...k-chips.com,
        wmc@...k-chips.com
Subject: Re: [PATCH 4/6] ARM: dts: rockchip: enable eMMC for rk3229-evb

Am Dienstag, 4. Juli 2017, 16:12:45 CEST schrieb Frank Wang:
> This patch enables eMMC support for rk3229-evb board.
> 
> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
> ---
>  arch/arm/boot/dts/rk3229-evb.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3229-evb.dts
> b/arch/arm/boot/dts/rk3229-evb.dts index b64f86c..bae0dbf 100644
> --- a/arch/arm/boot/dts/rk3229-evb.dts
> +++ b/arch/arm/boot/dts/rk3229-evb.dts
> @@ -130,6 +130,17 @@
>  	cpu-supply = <&vdd_arm>;
>  };
> 
> +&emmc {
> +	broken-cd;
> +	bus-width = <8>;
> +	cap-mmc-highspeed;
> +	supports-emmc;
> +	disable-wp;
> +	non-removable;

non-removable should be enough, so you shouldn't need the broken-cd above?

> +	num-slots = <1>;
> +	status = "okay";
> +};
> +
>  &gmac {
>  	assigned-clocks = <&cru SCLK_MAC_EXTCLK>, <&cru SCLK_MAC>;
>  	assigned-clock-parents = <&ext_gmac>, <&cru SCLK_MAC_EXTCLK>;