linux-kernel - Re: [PATCH 1/1] bridge: mdb: report complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170704.014842.1942928249505987408.davem@davemloft.net>
Date:   Tue, 04 Jul 2017 01:48:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eduval@...zon.com
Cc:     stephen@...workplumber.org, bridge@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a
 kmemleak

From: Eduardo Valentin <eduval@...zon.com>
Date: Mon, 3 Jul 2017 10:06:34 -0700

> We currently get the following kmemleak report:
 ...
> This patch flags the complete_info ptr object as not a leak as it will
> get freed when .complete_priv() is called,

We don't call .complete_priv().  We call .complete().

 for the br mdb case, it
> will be freed at br_mdb_complete().
> 
> Cc: stable <stable@...r.kernel.org> # v4.9+
> Reviewed-by: Vallish Vaidyeshwara <vallish@...zon.com>
> Signed-off-by: Eduardo Valentin <eduval@...zon.com>

I don't understand why kmemleak cannot see this.

We store the pointer globally when we do the switchdev_port_obv_add()
call and it should be able to see that.