linux-kernel - Re: [PATCH] staging: comedi: Use offset_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fd3d16e-d2ec-2fde-b4c1-fc32e659e048@mev.co.uk>
Date:   Tue, 4 Jul 2017 10:36:48 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Amitoj Kaur Chawla <amitoj1606@...il.com>,
        hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: Use offset_in_page macro

On 04/07/17 00:13, Amitoj Kaur Chawla wrote:
> Use offset_in_page macro instead of (var & ~PAGE_MASK)
>
> The Coccinelle semantic patch used to make this change is as follows:
> // <smpl>
> @@
> unsigned long p;
> @@
> - p & ~PAGE_MASK
> + offset_in_page(p)
> // </smpl>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/staging/comedi/comedi_buf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_buf.c b/drivers/staging/comedi/comedi_buf.c
> index 8e9b30b..b455ff6 100644
> --- a/drivers/staging/comedi/comedi_buf.c
> +++ b/drivers/staging/comedi/comedi_buf.c
> @@ -165,7 +165,7 @@ int comedi_buf_map_put(struct comedi_buf_map *bm)
>  int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned long offset,
>  			  void *buf, int len, int write)
>  {
> -	unsigned int pgoff = offset & ~PAGE_MASK;
> +	unsigned int pgoff = offset_in_page(offset);
>  	unsigned long pg = offset >> PAGE_SHIFT;
>  	int done = 0;
>
>

Seems reasonable, thanks.  Being picky, I'd prefer it if the line 
`#include <linux/mm.h>` was added, since that is where the 
`offset_in_page` macro is defined.  But it doesn't matter that much as 
the "mm.h" header file gets included indirectly, and there are plenty of 
examples where `offset_in_page` is used without including <linux/mm.h> 
directly.

Signed-off-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-