linux-kernel - Re: [PATCH] bus: arm-ccn: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1499167621.2752.16.camel@arm.com>
Date:   Tue, 04 Jul 2017 12:27:01 +0100
From:   Pawel Moll <pawel.moll@....com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        mark.rutland@....com, mingo@...nel.org
Subject: Re: [PATCH] bus: arm-ccn: constify attribute_group structures.

On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by  work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    9074	   5592	    416	  15082	   3aea	drivers/bus/arm-ccn.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    9327	   5336	    416	  15079	   3ae7	drivers/bus/arm-ccn.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Looks fine to me. I'll queue it for the next time I push out CCN driver
fixes (no dates promised, though...)

Thanks!

Paweł