linux-kernel - Re: [PATCH 1/2] arm64: dts: add Spreadtrum's fm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170704123510.GC21587@leverpostej>
Date:   Tue, 4 Jul 2017 13:35:11 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Chunyan Zhang <chunyan.zhang@...eadtrum.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Songhe Wei <songhe.wei@...eadtrum.com>,
        Zhongping Tan <zhongping.tan@...eadtrum.com>,
        Orson Zhai <orson.zhai@...eadtrum.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH 1/2] arm64: dts: add Spreadtrum's fm support

On Tue, Jul 04, 2017 at 06:15:07PM +0800, Chunyan Zhang wrote:
> Added FM support for Spreadtrum's SP9860 board.
> 
> Signed-off-by: Songhe Wei <songhe.wei@...eadtrum.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@...eadtrum.com>
> ---
>  arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> index 0362ecd..6fe052d 100644
> --- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> @@ -39,6 +39,10 @@
>  		#size-cells = <2>;
>  		ranges;
>  	};
> +
> +	sprd-fm {
> +		compatible  = "sprd,marlin2-fm";
> +	};

What kind of device is this? MMIO?

It seems to be sitting directly under the root node, but has no reg or
relationship with another bus defined, so something is missing.

This will need binding documentation.

Thanks,
Mark.


>  };
>  
>  &uart0 {
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html