linux-kernel - Re: [PATCH 5/6] i2c: pca-platform: use device_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170704140706.p3yvxzc6722jeexs@ninjato>
Date:   Tue, 4 Jul 2017 16:07:06 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Linux-SH <linux-sh@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32


> >> Frankly, I am not a big fan of converting board files if we cannot test
> >> the changes.
> > 
> > So, if no one is using that old boards, should we really take care
> > more than just compile test?
> > 
> > P.S. Legacy platform data makes a burden of development nowadays.
> > Built-in device properties API (as a part of Unified Device
> > Properties) is exactly for getting rid of legacy stuff and make things
> > much cleaner.
> 
> We could probably go with an approach of making the device properties 
> the default which would suit the new style and leave the platform_data 
> to override things if it is present.
> 
> If/when the older platforms go away we can drop struct 
> i2c_pca9564_pf_platform_data.

I don't have a super strong opinion, so we can discuss this for 4.14.
For 4.13, I picked the two easy patches already. Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)