linux-kernel - Re: [PATCH v2] ideapad-laptop: Add several models to no_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeehPzhDJ81PGB1Y-DFu5fT+jLmMXmdgKh3et=KF1YZdg@mail.gmail.com>
Date:   Tue, 4 Jul 2017 17:21:45 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Yang Jiaxun <yjx@...goat.com>
Cc:     Ike Panhc <ike.pan@...onical.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ideapad-laptop: Add several models to no_hw_rfkill

On Tue, Jul 4, 2017 at 5:06 PM, Yang Jiaxun <yjx@...goat.com> wrote:
> From daaa74f5b5f8ecfad4d452af787276f8c43f79b9 Mon Sep 17 00:00:00 2001
> From: Yang Jiaxun <yjx@...goat.com>
> Date: Tue, 4 Jul 2017 13:49:41 +0000
> Subject: [PATCH v2] ideapad-laptop: Add several models to no_hw_rfkill

Something is still wrong with the method how you send patches. The
above should be absent in usual case.

I would recommend to use git send-email tool.

If it sounds a big deal I would apply it manually.

>
> Some Lenovo ideapad models do not have hardware rfkill switches, but
> trying to read the rfkill switches through the ideapad-laptop module.
> It caused to always reported blocking breaking wifi.
>
> Fix it by adding those models to no_hw_rfkill_list.
>
> Signed-off-by: Yang Jiaxun <yjx@...goat.com>
> ---
>  drivers/platform/x86/ideapad-laptop.c | 70
> +++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> index 24ca9fbe31cc..5f4515b88a18 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -869,6 +869,27 @@ static const struct dmi_system_id no_hw_rfkill_list[] =
> {
>
>          },
>      },
>      {
> +        .ident = "Lenovo V310-14IKB",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V310-14IKB"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo V310-14ISK",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V310-14ISK"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo V310-15IKB",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V310-15IKB"),
> +        },
> +    },
> +    {
>          .ident = "Lenovo V310-15ISK",
>          .matches = {
>                  DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> @@ -876,6 +897,48 @@ static const struct dmi_system_id no_hw_rfkill_list[] =
> {
>          },
>      },
>      {
> +        .ident = "Lenovo ideapad 300-15IBR",
>
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 300-15IBR"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo ideapad 300-15IKB",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 300-15IKB"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo ideapad 300S-11IBR",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 300S-11BR"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo ideapad 310-15ABR",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 310-15ABR"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo ideapad 310-15IAP",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 310-15IAP"),
> +        },
> +    },
> +    {
> +        .ident = "Lenovo ideapad 310-15ISK",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 310-15ISK"),
> +        },
> +    },
> +    {
>          .ident = "Lenovo ideapad 310-15IKB",
>          .matches = {
>                  DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> @@ -883,6 +946,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] =
> {
>          },
>      },
>      {
> +        .ident = "Lenovo ideapad Y700-14ISK",
> +        .matches = {
> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +            DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700-14ISK"),
> +        },
> +    },
> +    {
>          .ident = "Lenovo ideapad Y700-15ACZ",
>          .matches = {
>              DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> --
> 2.13.2
>



-- 
With Best Regards,
Andy Shevchenko