linux-kernel - Re: [PATCH] video: fbdev: aty: remove useless variable assignments in aty_var_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <30595844.JA8gAC7Mhf@amdc3058>
Date:   Tue, 04 Jul 2017 17:00:57 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: aty: remove useless variable assignments
 in aty_var_to_crtc()

On Monday, June 26, 2017 05:05:18 PM Gustavo A. R. Silva wrote:
> Value assigned to variable vdisplay at line 990 is overwritten
> at line 1039 before it can be used. Also, variable assignment
> at line 987 is the same as at line 1039. This makes such
> variable assignments useless.
> 
> Remove these variable assignments and the code related.
> 
> Addresses-Covertity-ID: 1226900
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Patch queued for 4.13, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics