linux-kernel - Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKMK7uF79R++M+HkYUtp1UrUfkesbUm=p3eRU2x30_cHEHiBdw@mail.gmail.com>
Date:   Tue, 4 Jul 2017 20:12:08 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Chris Wilson <chris@...is-wilson.co.uk>,
        Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        Guneshwor Singh <guneshwor.o.singh@...el.com>,
        Hardik T Shah <hardik.t.shah@...el.com>,
        Libin Yang <libin.yang@...el.com>,
        "Subhransu S. Prusty" <subhransu.s.prusty@...el.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Jaroslav Kysela <perex@...ex.cz>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

On Tue, Jul 4, 2017 at 5:28 PM, Takashi Iwai <tiwai@...e.de> wrote:
> On Tue, 04 Jul 2017 17:14:39 +0200,
> Daniel Vetter wrote:
>> On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter <daniel@...ll.ch> wrote:
>> >> Now I took a closer look, and this appears rather like a brown paper
>> >> bag bug, not about the deferred probe or module dependency.
>> >> The fix patch is below.  Could you check whether it works?
>> >
>> > Yay, this works!
>> >
>> > Tested-by: Daniel Vetter <daniel.vetter@...ll.ch>
>>
>> Next one: i915 module reloading is broken because something is holding
>> onto a module reference and doesn't drop it. Didn't check which sets
>> of patches introduced this, but iirc this worked last week. Disabling
>> hda-intel gets in Kconfig gets rid of the problem, so I assume
>> something in the sound driver is leaking that reference ...
>>
>> It's also causing lots and lots of red in our CI :( If we can't fix
>> this we need to disable snd-hda-intel there too.
>
> I spotted out a typo in my previous patch that leads to the module
> reference unbalance.  The fix is  already in sound.git tree today:
>   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&id=fc18282cdcba984ab89c74d7e844c10114ae0795
>
> The bug was introduced after 4.12.

Ok, CI over here confirmed that it's all good again.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch