linux-kernel - [BUG] checkpatch: false positive storage class location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170704192901.23126-1-xypron.glpk@gmx.de>
Date:   Tue,  4 Jul 2017 21:29:01 +0200
From:   Heinrich Schuchardt <xypron.glpk@....de>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org, u-boot@...ts.denx.de,
        Heinrich Schuchardt <xypron.glpk@....de>
Subject: [BUG] checkpatch: false positive storage class location

The U-Boot project uses the same scripts/checkpatch.pl as the Linux
kernel. I ran upon the problem below when working on U-Boot. But I
guess it should be fixed in the Linux upstream.

Running checkpatch for this email produces
WARNING: storage class should be at the beginning of the declaration

This relates to the parameter with asmlinkage.

asmlinkage is at the start of the parameter so I think this a false
positive.

Signed-off-by: Heinrich.Schuchardt <xypron.glpk@....de>
---

 cmd/bootefi.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index 771300ee94..4df468307c 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -147,6 +147,12 @@ static void *copy_fdt(void *fdt)
 	return new_fdt;
 }
 
+static ulong efi_do_enter(void *image_handle,
+		struct efi_system_table *st, asmlinkage ulong (*entry)(
+		void *image_handle, struct efi_system_table *st))
+{
+	return 0;
+}
+
 /*
 end
 */
-- 
2.11.0