linux-kernel - Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hbmp0c6a3.wl-tiwai@suse.de>
Date:   Tue, 04 Jul 2017 22:10:28 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Haojian Zhuang" <haojian.zhuang@...il.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Lee Jones" <lee.jones@...aro.org>,
        "Lars-Peter Clausen" <lars@...afoo.de>,
        "Charles Keepax" <ckeepax@...nsource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Daniel Mack" <daniel@...que.org>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 02/12] ALSA: ac97: add an ac97 bus

On Tue, 04 Jul 2017 21:37:48 +0200,
Robert Jarzmik wrote:
> 
> Takashi Iwai <tiwai@...e.de> writes:
> 
> > On Fri, 30 Jun 2017 21:43:58 +0200,
> > Robert Jarzmik wrote:
> >> +static struct bus_type ac97_bus_type = {
> >> +	.name		= "ac97",
> >
> > Name-conflict with the old ac97 bus?
> Yeah, fair point. So what should I choose for this new one ?
>  - ac97new
>  - ac97bis
>  - ac97_2
>  - ac97reborn

ac97bus
ac97_episode_5
ac98
...

I have no opinion on it.


> >> +static int __init ac97_bus_init(void)
> >> +{
> >> +	return bus_register(&ac97_bus_type);
> >> +}
> >> +subsys_initcall(ac97_bus_init);
> >> +
> >> +MODULE_LICENSE("GPL");
> >> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@...e.fr>");
> >
> > No bus_unregister() at exit?
> Mmmh, that's because I used subsys_initcall(), which doesn't look good in a
> module compilation setup. That will require a module_init(), and I will think
> about how to implement it and test it for next iteration.

You can use subsys_init() for modules, it's no problem.
When it's built for a module, all xxx_init() is handled as equivalent
with module_init().  See linux/module.h.

It's just the lack of module_exit() in your case.


thanks,

Takashi