linux-kernel - [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170704215526.GA10933@embeddedgus>
Date:   Tue, 4 Jul 2017 16:55:26 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Cliff Whickman <cpw@....com>, Robin Holt <robinmholt@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: [PATCH] sgi-xpc: remove unnecessary static in
 xpc_setup_msg_structures_uv()

Remove unnecessary static on local variable _ret_.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size.
This log is the output of the size command, before and after the
code change:

before:
   text    data     bss     dec     hex filename
  25457    3056     448   28961    7121 drivers/misc/sgi-xp/xpc_uv.o

after:
   text    data     bss     dec     hex filename
  25405    3000     384   28789    7075 drivers/misc/sgi-xp/xpc_uv.o

Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
---
 drivers/misc/sgi-xp/xpc_uv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 340b44d..6581eba 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -1151,7 +1151,7 @@ xpc_allocate_recv_msg_slot_uv(struct xpc_channel *ch)
 static enum xp_retval
 xpc_setup_msg_structures_uv(struct xpc_channel *ch)
 {
-	static enum xp_retval ret;
+	enum xp_retval ret;
 	struct xpc_channel_uv *ch_uv = &ch->sn.uv;
 
 	DBUG_ON(ch->flags & XPC_C_SETUP);
-- 
2.5.0