linux-kernel - Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b43c0c9b-37c0-466c-4d17-7fc26ca07060@microchip.com>
Date:   Wed, 5 Jul 2017 10:03:49 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Colin King <colin.king@...onical.com>, <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][-next] net: macb: remove extraneous return when
 MACB_EXT_DESC is defined

On 04/07/2017 at 17:09, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> When macro MACB_EXT_DESC is defined we end up with two identical
> return statements and just one is sufficient. Remove the extra
> return.
> 
> Detected by CoverityScan, CID#1449361 ("Structurally dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>  drivers/net/ethernet/cadence/macb_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 41e5711544fc..e69ebdd65658 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -146,7 +146,6 @@ static unsigned int macb_adj_dma_desc_idx(struct macb *bp, unsigned int desc_idx
>  	default:
>  		break;
>  	}
> -	return desc_idx;
>  #endif
>  	return desc_idx;
>  }
> 


-- 
Nicolas Ferre