linux-kernel - Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170705.090908.458530250899642598.davem@davemloft.net>
Date:   Wed, 05 Jul 2017 09:09:08 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the
 TCP_BPF_SNDCWND_CLAMP case

From: Colin King <colin.king@...onical.com>
Date: Tue,  4 Jul 2017 16:21:12 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
> 
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
> 
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.