linux-kernel - [PATCH] btrfs: Correct assignment of pos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170705000209.11391-1-rgoldwyn@suse.de>
Date:   Tue,  4 Jul 2017 19:02:09 -0500
From:   Goldwyn Rodrigues <rgoldwyn@...e.de>
To:     linux-btrfs@...r.kernel.org
Cc:     linux-block@...r.kernel.org, markus@...ppelsdorf.de,
        linux-kernel@...r.kernel.org, axboe@...nel.dk, dsterba@...e.com,
        Goldwyn Rodrigues <rgoldwyn@...e.com>
Subject: [PATCH] btrfs: Correct assignment of pos

From: Goldwyn Rodrigues <rgoldwyn@...e.com>

Assigning pos for usage early messes up in append mode, where
the pos is re-assigned in generic_write_checks(). Re-assign
pos to get the correct position to write from iocb->ki_pos.

Fixes: edf064e7c6fe ("btrfs: nowait aio support")
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@...e.com>
Tested-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
---
 fs/btrfs/file.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 59e2dccdf75b..7947781229e5 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1931,6 +1931,7 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb,
 	 */
 	update_time_for_write(inode);
 
+	pos = iocb->ki_pos;
 	start_pos = round_down(pos, fs_info->sectorsize);
 	oldsize = i_size_read(inode);
 	if (start_pos > oldsize) {
-- 
2.12.0