linux-kernel - Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Jul 2017 11:11:46 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     Jaechul Lee <jcsing.lee@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        alsa-devel <alsa-devel@...a-project.org>,
        Jaechul Lee <galaxyra@...il.com>,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: samsung: i2s: Supported high resolution rates

On Wed, Jul 05, 2017 at 03:13:23PM +0900, Andi Shyti wrote:

> > +	if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)

> I do not like drivers to check the Kernel's configuration, I
> think just checking "pdev->dev.of_node" is enough.

This idiom gets used because it allows the compiler to optimize out the
DT section if the kernel is built without DT support, it's fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)