linux-kernel - Re: [PATCH v2] perf sort: only insert overhead && overhead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170705030251.GA23139@intel.com>
Date:   Wed, 5 Jul 2017 11:02:51 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     "Du, Changbin" <changbin.du@...el.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf sort: only insert overhead && overhead_children
 when no overhead* field given

On Thu, Jun 29, 2017 at 05:22:52PM +0200, Jiri Olsa wrote:
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > >  	if (sort__mode == SORT_MODE__DIFF)
> > >  		return keys;
> > >  
> > > +	if (strstr(keys, "overhead"))
> > > +		return keys;
> > > +
> 
> ah ok, I think it's right.. basically you're forcing
> precedence of the -s option over the --children option
> 
> you could have your example working by running:
>   $ perf report -s overhead,sym --no-children
> 
Thanks for the knowledge.

> please state something like:
> 
> /*
>  * User already stated overhead within -s option,
>  * do not mangle with that.
>  */
> 
I'll add this as comment around the change for v3.

> thanks,
> jirka

-- 
Thanks,
Changbin Du

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)