linux-kernel - Re: [PATCH 0/5] Update kernel to latest FMC bus release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170705102713.GA20907@mail.gnudd.com>
Date:   Wed, 5 Jul 2017 12:27:13 +0200
From:   Alessandro Rubini <rubini@...dd.com>
To:     riehecky@...l.gov
Cc:     linux-kernel@...r.kernel.org, drivers_other@...nel-bugs.osdl.org,
        gregkh@...uxfoundation.org, federico.vaga@...n.ch
Subject: Re: [PATCH 0/5] Update kernel to latest FMC bus release

Hello.

Thank you Pat for taking care of these patches.

> Federico Vaga (5):
>   drivers/fmc: remove unused variable
>   drivers/fmc: hide fmc operations behind helpers
>   drivers/fmc: The only way to dump the SDB is from debugfs
>   drivers/fmc: change registration prototype
>   drivers/fmc: carrier can program FPGA on registration

The main problem with your patches, as submitted, is that they miss
the "From:" line to attribute Federico as author.  Then I think you
might add your own "Tested-by:".

I want to ack them but I'd love to run them first to have a second
check.  I should definitely manage it in a pair of days
more. Meanwhile, if you want to post V2 with the fixes above that
would be great. If needed, you can write me offlist.

thankyou for your submission and your patience
/alessandro