linux-kernel - Re: [Xen-devel] [PATCH v2] xen/balloon: don't online new memory initially

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <595D273A0200007800168CFF@prv-mh.provo.novell.com>
Date:   Wed, 05 Jul 2017 09:51:54 -0600
From:   "Jan Beulich" <JBeulich@...e.com>
To:     "Juergen Gross" <jgross@...e.com>
Cc:     <xen-devel@...ts.xenproject.org>, <boris.ostrovsky@...cle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen/balloon: don't online new
 memory initially

>>> On 05.07.17 at 17:38, <jgross@...e.com> wrote:
> @@ -94,22 +103,15 @@ static struct notifier_block xenstore_notifier = {
>  	.notifier_call = balloon_init_watcher,
>  };
>  
> -static int __init balloon_init(void)
> +void __init xen_balloon_init(void)
>  {
> -	if (!xen_domain())
> -		return -ENODEV;
> -
> -	pr_info("Initialising balloon driver\n");
> -
>  	register_balloon(&balloon_dev);
>  
>  	register_xen_selfballooning(&balloon_dev);
>  
>  	register_xenstore_notifier(&xenstore_notifier);
> -
> -	return 0;
>  }
> -subsys_initcall(balloon_init);
> +EXPORT_SYMBOL_GPL(xen_balloon_init);

I'm sorry for not having paid attention at v1, but __init functions
should not be exported (I would hope for you to actually see a
warning with CONFIG_DEBUG_SECTION_MISMATCH=y).

Jan