linux-kernel - Re: [PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLXG027SJr0Yk+R10LKLYawMB_Rwxm419wPq-c-3OUN2Og@mail.gmail.com>
Date:   Wed, 5 Jul 2017 12:45:30 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...eaurora.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] alarmtimer: Fix unavailable wake-up source in sysfs

On Wed, Jul 5, 2017 at 5:08 AM, Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> Currently the alarmtimer registers a wake-up source unconditionally,
> regardless of the system having a (wake-up capable) RTC or not.
> Hence the alarmtimer will always show up in
> /sys/kernel/debug/wakeup_sources, even if it is not available, and thus
> cannot be a wake-up source.
>
> To fix this, postpone registration until a wake-up capable RTC device is
> added.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v2:
>   - Move ws inside #ifdef CONFIG_RTC_CLASS to avoid a defined but not
>     used warning if CONFIG_RTC_CLASS is disabled,
>   - Reword.


This looks ok to me. I've queued it up for testing, targeting 4.14.
Let me know if its more urgent.

thanks
-john