linux-kernel - Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201707052224.20656@pali>
Date:   Wed, 5 Jul 2017 22:24:20 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     David Airlie <airlied@...hat.com>
Cc:     "Chun-Yi Lee" <jlee@...e.com>,
        Corentin Chary <corentin.chary@...il.com>,
        acpi4asus-user@...ts.sourceforge.net,
        Oleksij Rempel <linux@...pel-privat.de>,
        João Paulo Rechi Vita <jprvita@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Wednesday 05 July 2017 21:30:35 David Airlie wrote:
> ----- Original Message -----
> 
> > From: "Pali Rohár" <pali.rohar@...il.com>
> > To: "Chun-Yi Lee" <jlee@...e.com>, "Corentin Chary"
> > <corentin.chary@...il.com>, acpi4asus-user@...ts.sourceforge.net,
> > "Dave Airlie" <airlied@...hat.com>, "Oleksij Rempel"
> > <linux@...pel-privat.de>, "João Paulo Rechi Vita"
> > <jprvita@...il.com>
> > Cc: "Darren Hart" <dvhart@...radead.org>, "Andy Shevchenko"
> > <andy@...radead.org>, "Andy Lutomirski" <luto@...nel.org>,
> > platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
> > Sent: Wednesday, 5 July, 2017 7:51:13 PM
> > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method
> > instance number
> > 
> > On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
> > > > So problematic drivers which use instance=1 without any comments
> > > > are:
> > > >   acer-wmi
> > > >   asus-wmi
> > > >   mxm-wmi
> > > 
> > > Adding authors & maintainers of those drivers in loop.
> > 
> > Hi!
> > 
> > Dell drivers and acer-wmi are fixed now. So only asus-wmi and
> > mxm-wmi needs to be investigated.
> > 
> > Adding more people who developed those drivers recently in loop.
> > Can you check if instance number is used correctly or not?
> 
> I've no memory of why I picked 1 or 0, I probably cut-n-paste it from
> somewhere else.
> 
> Dave.

And do you have at least ACPI DSDT dumps from that machine? Or are you 
able to find some?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)