linux-kernel - [QUESTION] perf annotate: how do we fix the 'total period' feature ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7a611a6-1544-ae69-9068-0c65ca6313cf@gmail.com>
Date:   Wed, 5 Jul 2017 14:47:47 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Milian Wolff <milian.wolff@...b.com>
Subject: [QUESTION] perf annotate: how do we fix the 'total period' feature ?

Hi,

Two problems of perf-annotate were mentioned in recent PATCH reviews
by Milian and Namhyung.

Currently perf-annotate has a '--show-total-period' option
and a 't' key "Toggle total period view" on TUI browser.

However, they actually show the number of samples, not period(Raw number 
of event count of sample).
So it's a different number to the perf report like below.

For example,

   $ perf report --stdio --show-nr-sample --show-total-period -S hex2u64
...
# Overhead       Samples        Period  Command  Shared Object
# ........  ............  ............  .......  .............
#
      3.07%            36      26484668  perf     perf


   $ perf annotate  --stdio --show-total-period -s hex2u64
  Percent |      Source code & Disassembly of perf for cycles:ppp (36 
samples)
-----------------------------------------------------------------------------
          :
          :
          :
          :      Disassembly of section .text:
          :
          :      000000000053ef9e <hex2u64>:
          :      hex2u64():
        0 :        53ef9e:       push   %rbp
        0 :        53ef9f:       mov    %rsp,%rbp
        0 :        53efa2:       sub    $0x30,%rsp
        1 :        53efa6:       callq  424810 
<pthread_attr_setdetachstate@...+0x10>
        0 :        53efab:       mov    %rdi,-0x28(%rbp)
        2 :        53efaf:       mov    %rsi,-0x30(%rbp)
...

Problems:
   1) the total period of perf-annotate is different from perf-report's
   2) perf-annotate only shows the first column as 'Percent'
      (even though the number of samples for each addr are actually printed)

So we need to just rename it ? ('total period' -> 'samples')

Or,
we should enable perf-annotate to support both features for 'periods' 
and 'samples' ?


Thanks,
Taeung