lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170705231429.lkwv4dt53jw32lbh@valkosipuli.retiisi.org.uk>
Date:   Thu, 6 Jul 2017 02:14:30 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Todor Tomov <todor.tomov@...aro.org>
Cc:     mchehab@...nel.org, sakari.ailus@...ux.intel.com,
        hansverk@...co.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] [media] ov5645: Add control to export CSI2 link
 frequency

On Wed, Jul 05, 2017 at 11:44:49AM +0300, Todor Tomov wrote:
> @@ -1231,6 +1246,13 @@ static int ov5645_probe(struct i2c_client *client,
>  						&ov5645_ctrl_ops,
>  						V4L2_CID_PIXEL_RATE,
>  						1, INT_MAX, 1, 1);
> +	ov5645->link_freq = v4l2_ctrl_new_int_menu(&ov5645->ctrls,
> +						   &ov5645_ctrl_ops,
> +						   V4L2_CID_LINK_FREQ,
> +						   ARRAY_SIZE(link_freq) - 1,
> +						   0, link_freq);
> +	if(ov5645->link_freq)

Thanks!

Applied the set, with the above typo fixed (i.e. space added).

> +		ov5645->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>  
>  	ov5645->sd.ctrl_handler = &ov5645->ctrls;
>  

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@....fi	XMPP: sailus@...iisi.org.uk

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ