linux-kernel - Re: [PATCH] tee: tee_shm: Constify dma_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170705065801.GB22143@jax>
Date:   Wed, 5 Jul 2017 08:58:03 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tee: tee_shm: Constify dma_buf_ops structures.

On Sat, Jul 01, 2017 at 05:56:06PM +0530, Arvind Yadav wrote:
> dma_buf_ops are not supposed to change at runtime. All functions
> working with dma_buf_ops provided by <linux/dma-buf.h> work with
> const dma_buf_ops. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2026	    112	      0	   2138	    85a	drivers/tee/tee_shm.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    2138	      0	      0	   2138	    85a	drivers/tee/tee_shm.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Looks good to me, queueing this.

Thanks,
Jens