linux-kernel - Re: [PATCH v4] drm/exynos/dsi: Remove error handling for bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <f27e4099-ee20-9a2c-6f71-02c209aa18d1@samsung.com>
Date:   Wed, 05 Jul 2017 16:09:43 +0900
From:   Hoegeun Kwon <hoegeun.kwon@...sung.com>
To:     inki.dae@...sung.com, jy0922.shim@...sung.com,
        sw0312.kim@...sung.com, airlied@...ux.ie, kgene@...nel.org,
        krzk@...nel.org
Cc:     javier@....samsung.com, a.hajda@...sung.com,
        tjakobi@...h.uni-bielefeld.de, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hoegeun Kwon <hoegeun.kwon@...sung.com>
Subject: Re: [PATCH v4] drm/exynos/dsi: Remove error handling for
 bridge_node DT parsing

Hi Inki,

Could you check this patch? :D

Best regards,
Hoegeun

On 06/21/2017 07:51 PM, Hoegeun Kwon wrote:
> Remove the error handling of bridge_node because the bridge_node is
> optional.
>
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is optional.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
> ---
>
> Hi all,
>
> Thanks for Krzysztof's advice.
>
> Changes for V4:
> - Fixed the word('optional') from commit message.
>
> Changes for V3:
> - Removed the word('required') from commit message.
>
> Changes for V2:
> - Modified the commit message in more detail than before.
>
> Best regards,
> Hoegeun
>
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   		return ret;
>   
>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> -	if (!dsi->bridge_node)
> -		return -EINVAL;
>   
>   	return 0;
>   }