linux-kernel - Re: [PATCH 2/2] genirq: Use is_fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABawtvNaH3suNuhFpTzP+UkrXwop6h+Kr86bT7MtOapVgeYBhg@mail.gmail.com>
Date:   Thu, 6 Jul 2017 13:46:05 +0800
From:   Ethan Zhao <ethan.kernel@...il.com>
To:     Hanjun Guo <guohanjun@...wei.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <marc.zyngier@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Ma Jun <majun258@...wei.com>,
        Agustin Vega-Frias <agustinv@...eaurora.org>,
        John Garry <john.garry@...wei.com>,
        Hanjun Guo <hanjun.guo@...aro.org>
Subject: Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly

Hanjun，

    What branch is this patch for ? Check v4.12, failed to apply.

Thanks,
Ethan

On Thu, Jul 6, 2017 at 12:35 PM, Hanjun Guo <guohanjun@...wei.com> wrote:
> From: Hanjun Guo <hanjun.guo@...aro.org>
>
> is_fwnode_irqchip() already check fwnode is NULL or not,
> just use is_fwnode_irqchip() directly.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 1bc38fa..14a21a3 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -137,7 +137,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
>         if (WARN_ON(!domain))
>                 return NULL;
>
> -       if (fwnode && is_fwnode_irqchip(fwnode)) {
> +       if (is_fwnode_irqchip(fwnode)) {
>                 fwid = container_of(fwnode, struct irqchip_fwid, fwnode);
>
>                 switch (fwid->type) {
> --
> 1.7.12.4
>