linux-kernel - Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170706150054.5706d4f2df3763dbb1d65320@kernel.org>
Date:   Thu, 6 Jul 2017 15:00:54 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kselftest@...r.kernel.org, shuah@...nel.org,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        naresh.kamboju@...aro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with
 "--logdir -"

On Wed, 5 Jul 2017 12:29:17 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 5 Jul 2017 12:25:06 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>  
> > > @@ -255,12 +262,18 @@ __run_test() { # testfile
> > >  # Run one test case
> > >  run_test() { # testfile
> > >    local testname=`basename $1`
> > > -  local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > +  if [ "$LOG_FILE" ] ; then  
> > 
> > Shouldn't this be
> > 
> > 	if [ ! -z "$LOG_FILE" ]; then
> > 
> > ?
> > 
> 
> OK, I just checked it out. I guess "" is considered zero and
> "<anything>" is considered 1.
> 
> Hmm, do we do this in other places too. Just makes me unconfortable.

OK, in that case, I can cleanup the code with [ ! -z "$VAR" ]

Thank you,

> 
> -- Steve
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>