linux-kernel - Re: [PATCH V1 4/5] spmi: pmic-arb: return the value instead of passing by pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170706064442.GY22780@codeaurora.org>
Date:   Wed, 5 Jul 2017 23:44:42 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Kiran Gunda <kgunda@...eaurora.org>
Cc:     Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicholas Troast <ntroast@...eaurora.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V1 4/5] spmi: pmic-arb: return the value instead of
 passing by pointer

On 07/03, Kiran Gunda wrote:
> Returning the output value from a function, when it is possible, is the
> better and cleaner way than passing it by the pointer. Hence, modify
> the ppid_to_apid mapping function to return apid instead of passing
> it by a pointer. While at it, pass the ppid as function parameter to
> ppid_to_apid mapping function instead of passing the sid and addr.
> 
> Signed-off-by: Kiran Gunda <kgunda@...eaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project