linux-kernel - Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c This is a patch to the dgnc_neo.c warning udealy to usleep range Signed-off-by: Yash Omer <yashomer0007@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jul 2017 09:31:53 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     yash007 <yashomer0007@...il.com>
Cc:     lidz.louin@...il.com, markh@...pro.net,
        Greg KH <gregkh@...uxfoundation.org>,
        driverdev-devel@...uxdriverproject.rog, devel@...verdev.osuol.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Staging: dgnc: I have fixed the changes in dgnc_neo.c
 This is a patch to the dgnc_neo.c warning udealy to usleep range
 Signed-off-by: Yash Omer <yashomer0007@...il.com>

Hi,

On Thu, Jul 6, 2017 at 3:49 AM, yash007 <yashomer0007@...il.com> wrote:
> From: Yash Omer <yash007@...s>

Instead of resending the same thing every time, could you instead fix
your commit message and send a v2?

Also, where's patch 1 of 2?

>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 1943e66..0034ebe 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1230,7 +1230,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
>                  */
>                 tmp = readb(&ch->ch_neo_uart->isr_fcr);
>                 if (tmp & 4)
> -                       udelay(10);
> +                       usleep_range(10);
>                 else
>                         break;
>         }
> @@ -1261,7 +1261,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
>                  */
>                 tmp = readb(&ch->ch_neo_uart->isr_fcr);
>                 if (tmp & 2)
> -                       udelay(10);
> +                       usleep_range(10);
>                 else
>                         break;
>         }
> @@ -1483,7 +1483,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
>         neo_pci_posting_flush(ch->ch_bd);
>
>         /* Give time for the UART to actually raise/drop the signals */
> -       udelay(10);
> +       usleep_range(10);
>  }
>
>  static void neo_send_start_character(struct channel_t *ch)
> @@ -1495,7 +1495,7 @@ static void neo_send_start_character(struct channel_t *ch)
>                 ch->ch_xon_sends++;
>                 writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
>                 neo_pci_posting_flush(ch->ch_bd);
> -               udelay(10);
> +               usleep_range(10);
>         }
>  }
>
> @@ -1508,7 +1508,7 @@ static void neo_send_stop_character(struct channel_t *ch)
>                 ch->ch_xoff_sends++;
>                 writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
>                 neo_pci_posting_flush(ch->ch_bd);
> -               udelay(10);
> +               usleep_range(10);
>         }
>  }
>
> --
> 2.1.4
>