linux-kernel - Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPM=9tzVpuXZW1B8cO14wdAwAniHGnKfTkJH7rLHEERz6cLO=Q@mail.gmail.com>
Date:   Thu, 6 Jul 2017 10:42:31 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Keith Packard <keithp@...thp.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dave Airlie <airlied@...hat.com>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object
 leases [v3]

> +/**
> + * Lease mode resources, creating another drm_master.
> + */
> +struct drm_mode_create_lease {
> +       /** Pointer to array of object ids (__u32) */
> +       __u64 object_ids;
> +       /** Number of object ids */
> +       __u32 object_count;
> +       /** flags for new FD (O_CLOEXEC, etc) */
> +       __u32 flags;
> +
> +       /** Return: unique identifier for lessee. */
> +       __u32 lessee_id;
> +       /** Return: file descriptor to new drm_master file */
> +       __u32 fd;
> +};
> +
> +/**
> + * List lesses from a drm_master
> + */
> +struct drm_mode_list_lessees {
> +       /** Number of lessees.
> +        * On input, provides length of the array.
> +        * On output, provides total number. No
> +        * more than the input number will be written
> +        * back, so two calls can be used to get
> +        * the size and then the data.
> +        */
> +       __u32 count_lessees;
> +
> +       /** Pointer to lessees.
> +        * pointer to __u64 array of lessee ids
> +        */
> +       __u64 lessees_ptr;
> +};

I think this needs a pad ^.

> +
> +/**
> + * Get leased objects
> + */
> +struct drm_mode_get_lease {
> +       /** Number of leased objects.
> +        * On input, provides length of the array.
> +        * On output, provides total number. No
> +        * more than the input number will be written
> +        * back, so two calls can be used to get
> +        * the size and then the data.
> +        */
> +       __u32 count_objects;
> +
> +       /** Pointer to objects.
> +        * pointer to __u32 array of object ids
> +        */
> +       __u64 objects_ptr;

And this.

> +};
> +
> +/**
> + * Revoke lease
> + */
> +struct drm_mode_revoke_lease {
> +       /** Unique ID of lessee
> +        */
> +       __u32 lessee_id;

And this.

Dave.