linux-kernel - [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170706092058.20079-1-jrjang@gmail.com>
Date:   Thu,  6 Jul 2017 17:20:58 +0800
From:   jrjang@...il.com
To:     unlisted-recipients:; (no To-header on input)
Cc:     jrjang@...il.com, Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler

From: Jun-Ru Chang <jrjang@...il.com>

Commit b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain")
removes the device IRQ domain and uses gic_irq_domain_alloc() to
allocate the shared/local domain. However, the shared interrupt handler
is not set after allocating. It causes that the system hangs with
"unexpected IRQ" messages disaply.

And commit 8ada00a650ec ("irqchip/mips-gic: Replace static map with
dynamic") renames gic_irq_domain_alloc() to gic_irq_domain_map() to set
up the handler and chip. Fix this by setting the handle_level_irq
handler for shared interrupts.

Fixes: b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain")
Signed-off-by: Jun-Ru Chang <jrjang@...il.com>
---
Change in v2:
- changed commit message

 drivers/irqchip/irq-mips-gic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
index 929f8558bf1c..0a5fb30deb17 100644
--- a/drivers/irqchip/irq-mips-gic.c
+++ b/drivers/irqchip/irq-mips-gic.c
@@ -716,6 +716,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq,
 		if (err)
 			return err;

+		irq_set_handler(virq, handle_level_irq);
 		return gic_shared_irq_domain_map(d, virq, hwirq, 0);
 	}

-- 
2.13.2